AAF adapter #230
Merged
AAF adapter #230
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Turned off lots of debugging print statements.
… (only remove them from Stacks).
…range and in_offset/out_offset.
…identical to how Avid Media Composer flattens.
* Install PyAAF via wheel so the contrib AAF adapter tests run in CI. * Make OTIO_AAF_PYTHON_LIB optional. * Added some comments about dependencies only needed for contrib adapters.
|
Addresses #1 |
ssteinbach
approved these changes
Feb 9, 2018
| result[child.name] = str(child.mobID) | ||
| elif isinstance(child, aaf.mob.SourceMob): | ||
| result[child.name] = str(child.mobID) | ||
| # elif hasattr(child, "name"): |
There was a problem hiding this comment.
Commented out code - did you want to prune this out or leave this in for the future?
| # self.extendChildItems([item.dictionary()]) | ||
|
|
||
| # elif isinstance(item, DummyItem): | ||
| # self.extendChildItems(item.item) |
There was a problem hiding this comment.
More commented out code - did you want to prune this? Otherwise leaving a #@todo comment might help leave a note for future developers
| child.source_range.duration -= after.out_offset | ||
|
|
||
| for c, child in enumerate(thing): | ||
| _fix_transitions(child) |
There was a problem hiding this comment.
This looks like you don't need an enumerate, just a regular loop should do.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added an adapter for reading Advanced Authoring Format (AAF) compositions into OTIO.
This contrib adapter requires PyAAF 1.0.0 to work: https://github.com/markreidvfx/pyaaf/releases