Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

-- (double-dash) removes double quotes on Windows #1133

Closed
epkaz93 opened this issue Sep 28, 2021 · 3 comments · Fixed by #1139
Closed

-- (double-dash) removes double quotes on Windows #1133

epkaz93 opened this issue Sep 28, 2021 · 3 comments · Fixed by #1139

Comments

@epkaz93
Copy link

epkaz93 commented Sep 28, 2021

Rez Version: 2.95.0
Platform: Windows 10
Working Rez version: 2.69.6

Running rez commands with -- causes double quotes to be removed from arguments after --.

Example:

rez-env python -- python -c "print('hello world')"
 File "<string>", line 1
   print('hello
              ^
SyntaxError: EOL while scanning string literal

Escaping the double quotes appears to work:

rez-env python -- python -c \"print('hello world')\"
hello world
@nerdvegas
Copy link
Contributor

I'm thinking this may be a regression introduced in https://github.com/nerdvegas/rez/releases/tag/2.94.0. Is there any chance you could test with https://github.com/nerdvegas/rez/releases/tag/2.93.3 and see if that works?

@epkaz93
Copy link
Author

epkaz93 commented Sep 28, 2021

I'm thinking this may be a regression introduced in https://github.com/nerdvegas/rez/releases/tag/2.94.0. Is there any chance you could test with https://github.com/nerdvegas/rez/releases/tag/2.93.3 and see if that works?

Yeah it works correctly in 2.93.3

@nerdvegas
Copy link
Contributor

FYI fix coming soon. I fixed other shells in #1130, but what I'll do is revert cmd behaviour to that in 2.93.3 until someone can take a look and properly fix the escaping for cmd.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants