Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove all traces of Python 2 #1635

Open
5 of 8 tasks
JeanChristopheMorinPerso opened this issue Feb 11, 2024 · 6 comments
Open
5 of 8 tasks

Remove all traces of Python 2 #1635

JeanChristopheMorinPerso opened this issue Feb 11, 2024 · 6 comments
Labels
enhancement help wanted Help us improve rez

Comments

@JeanChristopheMorinPerso
Copy link
Member

JeanChristopheMorinPerso commented Feb 11, 2024

Support for Python 2 was removed in 3.0.0, but we left some leftovers. This issue lists what's left to be done to really remove all traces of Python 2 from the codebase.

Tasks

Preview Give feedback
  1. difficulty/easy enhancement help wanted
  2. difficulty/easy enhancement help wanted
  3. difficulty/hard enhancement help wanted
  4. devdays24 difficulty/easy enhancement help wanted
  5. difficulty/easy enhancement help wanted

If you want to start working on one of these task and it's not yet converted to an issue, please comment in the issue and we will happily create an issue.

List of Python 2 to 3 PRs

Note that there is a lot of noise in these PRs. But they can be used to see what kind of compatibility layers were added to support both python 2 and 3. This will be handy to determine if something should be removed.

@JeanChristopheMorinPerso JeanChristopheMorinPerso changed the title Remove Python 2 leftovers from the codebase Remove all traces of Python 2 Feb 11, 2024
@JeanChristopheMorinPerso JeanChristopheMorinPerso added the help wanted Help us improve rez label Feb 12, 2024
@hww-nikhilshankarnoble
Copy link

@JeanChristopheMorinPerso has anyone picked up the removal of rez.utils.py23 task yet? I was looking for a straightforward task to kickstart hopefully contributing to Rez more in the future, and would like to pick it up if not :)

@JeanChristopheMorinPerso
Copy link
Member Author

@hww-nikhilshankarnoble I don't think so. I have created #1646 if you want to work on it.

@lbreede
Copy link

lbreede commented Sep 20, 2024

@JeanChristopheMorinPerso has anyone tackled these magic methods yet?

Remove/replace all deprecated (python 2) magic methods ()

I may look into that as part of the Dev Days 2024.

@JeanChristopheMorinPerso
Copy link
Member Author

Hi @lbreede . I don't think anyone did that. Feel free to give it a try. But note that rez is not participating to the dez days and as such we might not be able to review your contributions in time. We still appreciate all contributions, so please do contribute if you can. We might be slow to review though.

@lbreede
Copy link

lbreede commented Sep 26, 2024

@JeanChristopheMorinPerso, I may just tackle it regardless. Is there an issue for this specific task yet?

@JeanChristopheMorinPerso
Copy link
Member Author

@lbreede I just created #1833.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement help wanted Help us improve rez
Projects
None yet
Development

No branches or pull requests

3 participants