Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

more informative return value of dex predeploy #2802

Open
shunjizhan opened this issue Aug 30, 2024 · 1 comment
Open

more informative return value of dex predeploy #2802

shunjizhan opened this issue Aug 30, 2024 · 1 comment

Comments

@shunjizhan
Copy link
Contributor

currently for our dex predeploy, all actions (swap, addliquidity, removeliquidity) returns bool. However, usually these actions return more informative data such as amountOut, shares, which will be helpful for predicting action result.

For example, if we want to get the estimated share amount when adding liquidity, now we have to do some manual calculation, which isn't that convenient

@zjb0807
Copy link
Member

zjb0807 commented Aug 30, 2024

These changes will affect the work of existing contracts. We can add some _v2 methods to implement it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants