Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

allow signed migration #2803

Merged
merged 1 commit into from
Sep 3, 2024
Merged

allow signed migration #2803

merged 1 commit into from
Sep 3, 2024

Conversation

xlc
Copy link
Member

@xlc xlc commented Sep 2, 2024

will include this into 2260 runtime

@xlc xlc requested a review from zjb0807 September 2, 2024 23:46
Copy link
Member

@zjb0807 zjb0807 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's better to adjust the deposit

pub MigrationSignedDepositPerItem: Balance = dollar(KAR);
pub MigrationSignedDepositBase: Balance = dollar(KAR);

https://github.com/polkadot-fellows/runtimes/blob/cf15699e1527f3bf4c76abd0287e62721bee428c/relay/polkadot/src/lib.rs#L1540-L1541

Copy link

codecov bot commented Sep 3, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 64.94%. Comparing base (4c725dd) to head (4ec9caa).
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2803      +/-   ##
==========================================
- Coverage   65.19%   64.94%   -0.25%     
==========================================
  Files          67       65       -2     
  Lines        9512     8635     -877     
==========================================
- Hits         6201     5608     -593     
+ Misses       3311     3027     -284     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@xlc
Copy link
Member Author

xlc commented Sep 3, 2024

only a single account can trigger migration so high deposit is not required

@xlc xlc merged commit 536bed6 into master Sep 3, 2024
6 checks passed
@xlc xlc deleted the allow-signed-migration branch September 3, 2024 02:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants