Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Update some dependencies to fix potential vulnerabilities #487

Merged
merged 3 commits into from
Dec 8, 2024

Conversation

DataTriny
Copy link
Member

@DataTriny DataTriny commented Dec 8, 2024

  • Updates tempfile (cargo update tempfile), which removes dependency on the instant crate, which fixes RUSTSEC-2024-0384.
  • Updates num_enum (cargo update num_enum) which removes an older version of hashbrown from the dependency tree.
  • Updates hashbrown (cargo update hashbrown) which fixes RUSTSEC-2024-0402.

Clippy fixes will come in a separate PR.

@DataTriny DataTriny changed the title fix: Update tempfile to 3.8.1 fix: Update some dependencies to fix potential vulnerabilities Dec 8, 2024
@mwcampbell
Copy link
Contributor

Since we're just updating Cargo.lock and not making any actual changes to any of the crates' Cargo.toml files, I think we can change this from a fix to a chore and eliminate the forced dependency bumps. The purpose of this is just to fix our own CI; we don't need to publish any new crate versions for this.

@DataTriny
Copy link
Member Author

You're right now that the bindings have moved. I'll revert these changes.

@DataTriny DataTriny changed the title fix: Update some dependencies to fix potential vulnerabilities chore: Update some dependencies to fix potential vulnerabilities Dec 8, 2024
Copy link
Contributor

@mwcampbell mwcampbell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are several nice simplifications to our Cargo.lock in here.

@mwcampbell mwcampbell merged commit f2c694b into main Dec 8, 2024
12 of 18 checks passed
@mwcampbell mwcampbell deleted the update-tempfile branch December 8, 2024 12:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants