Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor!: Drop Tree::app_name #492

Merged
merged 5 commits into from
Dec 8, 2024
Merged

refactor!: Drop Tree::app_name #492

merged 5 commits into from
Dec 8, 2024

Conversation

mwcampbell
Copy link
Contributor

@mwcampbell mwcampbell commented Dec 8, 2024

I now believe this property was a mistake.

On platforms where assistive technologies have conditional behavior based on the app name, they should get the app name from the platform, not the app itself. This way, correct behavior isn't dependent on the app or toolkit exposing the app name, and we don't give the app the opportunity to lie about its name.

Yes, AT-SPI requires the app to provide its own app name. I consider that a flaw in AT-SPI, which we should work around in the Unix adapter, rather than perpetuating it in our new cross-platform API. In Newton (the new free desktop accessibility stack I prototyped earlier this year), I want ATs to get the app name from the compositor, not the app itself, though I didn't implement that yet.

While I was here, I changed the toolkit_name and toolkit_version accessors in accesskit_consumer to return Option<&str> rather than cloning the Option<String>, since the latter is an unnecessary pessimization.

@DataTriny DataTriny merged commit 089794c into main Dec 8, 2024
9 checks passed
@DataTriny DataTriny deleted the drop-app-name branch December 8, 2024 21:33
@github-actions github-actions bot mentioned this pull request Dec 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants