Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I now believe this property was a mistake.
On platforms where assistive technologies have conditional behavior based on the app name, they should get the app name from the platform, not the app itself. This way, correct behavior isn't dependent on the app or toolkit exposing the app name, and we don't give the app the opportunity to lie about its name.
Yes, AT-SPI requires the app to provide its own app name. I consider that a flaw in AT-SPI, which we should work around in the Unix adapter, rather than perpetuating it in our new cross-platform API. In Newton (the new free desktop accessibility stack I prototyped earlier this year), I want ATs to get the app name from the compositor, not the app itself, though I didn't implement that yet.
While I was here, I changed the
toolkit_name
andtoolkit_version
accessors inaccesskit_consumer
to returnOption<&str>
rather than cloning theOption<String>
, since the latter is an unnecessary pessimization.