Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for uint, ushort, and ulong #21

Closed
admedina opened this issue Jun 3, 2019 · 3 comments
Closed

Add support for uint, ushort, and ulong #21

admedina opened this issue Jun 3, 2019 · 3 comments

Comments

@admedina
Copy link

admedina commented Jun 3, 2019

I am enjoying mustachio a lot! I am hoping that support for ushort, uint, and ulong could be added in the near future. Currently, those datatypes are not considered valid values. Could it have something to do with the _printableTypes in ContextObject.cs?
@vladsandu vladsandu mentioned this issue Jun 23, 2019
Merged
@vladsandu
Copy link
Contributor

Hey @admedina. It's awesome to hear that you enjoy Mustachio!
Regarding your question, you are correct. They are not considered valid values because they are not listed in the _printableTypes HashSet in ContextObject.cs.
I have added a PR with those changes and we will get that reviewed soon.

@admedina
Copy link
Author

Thank you @vladsandu!

@vladsandu
Copy link
Contributor

Closed by PR #22. Merged and version 2.1.0 released on NuGet.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@vladsandu @admedina