fix: improve AW_WEBUI_DIR handling #424
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #424 +/- ##
=======================================
Coverage 73.37% 73.37%
=======================================
Files 45 45
Lines 2794 2794
=======================================
Hits 2050 2050
Misses 744 744 ☔ View full report in Codecov by Sentry. |
|
Good catch! |
ErikBjare
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Otherwise,
../aw-webui/distis always created which contradicts the flexibility from the env variable. Also, ifAW_WEBUI_DIRis already and explicitly set then it supposedly means that the build runner has taken care of the matter.Follow up on #385