Skip to content

Commit

Permalink
fix: set uncategorized notification isVisible ratio to 0.3, disabled …
Browse files Browse the repository at this point in the history
…when category query param set
  • Loading branch information
ErikBjare committed Apr 11, 2023
1 parent b8d65fc commit 03caaa0
Showing 1 changed file with 3 additions and 1 deletion.
4 changes: 3 additions & 1 deletion src/components/UncategorizedNotification.vue
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,9 @@ export default {
: 0;
},
isVisible() {
return this.ratio > 0.2;
// if ratio is > 0.3, show it // TODO: make configurable
// if there's a category filter (url has category query param), don't show it
return this.ratio > 0.3 && !this.$route.query.category;
},
},
};
Expand Down

1 comment on commit 03caaa0

@github-actions
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here are screenshots of this commit:

Screenshots using aw-server v0.12.1 (click to expand)

Screenshots using aw-server-rust master (click to expand)

Screenshots using aw-server-rust v0.12.1 (click to expand)

Please sign in to comment.