-
-
Notifications
You must be signed in to change notification settings - Fork 108
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: better explain how to use pre-releases for dev/testing #373
docs: better explain how to use pre-releases for dev/testing #373
Conversation
There is no `static` folder in case of aw-server-rust (unlike aw-server-python), even while packaging rust server, files are directly taken from `aw-server-rust/aw-webui/dist/`. https://github.com/ActivityWatch/aw-server-rust/blob/7c2b31f173194d75634079128a27ed06d83365b1/Makefile#L86
Files are only taken from Closing. If I've misunderstood, do let me know. |
The documentation is a little confusing, i thought it was taking about the soruceTree's aw-server dir when Here sourceTree means the folder where we git clone'd or the folder containing the source files. When building from source in sourceTree, makefile of aw-server-python will create a I still feel that the doc is still confusing, my recommendation,
to
Intended use: Improves dev on-boarding |
Codecov ReportBase: 25.58% // Head: 25.58% // No change to project coverage 👍
Additional details and impacted files@@ Coverage Diff @@
## master #373 +/- ##
=======================================
Coverage 25.58% 25.58%
=======================================
Files 26 26
Lines 1442 1442
Branches 226 223 -3
=======================================
Hits 369 369
- Misses 1020 1044 +24
+ Partials 53 29 -24
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
Ah, I can certainly see how that is confusing. I think changing around how the source tree folder structure looks so that it looks the same as for the installation isn't really possible due to constraints of packaging (it might be, but it would be a mess to change). There will always be a path disparity, and the current one is good enough. But I'm all for improving the language of the README to make it clear.
I think this suggestion is good. Could you update this PR with this and maybe other changes that would clarify/simplify it? I'll take a second pass at it when you're done :) |
Updated with some restructuring too :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice, just a few things.
Merged! Thanks for this @ShootingKing-AM ❤️ |
Thanks for the quick review and merge! 🎉
ref: https://cli.vuejs.org/guide/deployment.html#previewing-locally |
There is no generated
static
folder in case of aw-server-rust (unlike aw-server-python), even while packaging rust server, files are directly taken fromaw-server-rust/aw-webui/dist/
.aw-server-rust/Makefile