Removes too many parentheses in macro definition

[rlipscombe]

From erlang-ls/erlang_ls#1168

I've got the following macro:

% note the parens:
-define(METRICS, (application:get_env(?APP, metrics_module, ?DEFAULT_METRICS_MODULE))).
%                ^                                                                  ^

...which I use like this:

notify_cache_hit() -> ?METRICS:increment(cache_hits).

When I run the formatter, it removes the parentheses, giving me this:

% this is wrong:
-define(METRICS, application:get_env(?APP, metrics_module, ?DEFAULT_METRICS_MODULE)).

This is incorrect, and causes syntax error before: ':' errors when I attempt to use the macro.

I've confirmed that this happens with rebar3_format v1.0.1, outside of ErlangLS.

[elbrujohalcon]

Thanks for the report, @rlipscombe … It's likely related to #74 and #216.

Macros with code in them are generally a pain point for the formatter.

Also for code maintainers…