Fix #263: Support OTP24 #300
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
elbrujohalcon
commented
Apr 11, 2022
Comment on lines
+512
to
+515
| {_, PrecR} = preop_prec('catch'), | ||
| D = lay(erl_syntax:catch_expr_body(Node), set_prec(Ctxt, PrecR)), | ||
| D1 = follow(text("catch"), D, Ctxt#ctxt.break_indent), | ||
| maybe_parentheses(D1, Prec, Ctxt); | ||
| maybe_parentheses(D1, 0, Ctxt); |
There was a problem hiding this comment.
I basically preserved OTP23 and prior value here. Using the one in OTP24 would work, too, but nobody actually complained about the extra parentheses and maintaining a formatter that formats the code consistently is better than maintaining one that produces different output depending on the OTP version with which it was compiled.
There was a problem hiding this comment.
Once we stop supporting OTP23… we can revisit this.
pablocostass
approved these changes
Apr 11, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #263: Support OTP24