Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Kunzite - Carline Senat & Danica Sarmiento #13

Open
wants to merge 12 commits into
base: main
Choose a base branch
from

Conversation

lattei
Copy link

@lattei lattei commented Apr 24, 2023

No description provided.

@lattei lattei changed the title Part 1 - Complete! Kunzite - Carline Senat & Danica Sarmiento Apr 24, 2023
Copy link

@spitsfire spitsfire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Stay consistent with your response bodies, though, and don't forget the status code!


@classmethod
def from_dict(cls, planet_data):
new_planet = Planet(name=planet_data["name"],

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
new_planet = Planet(name=planet_data["name"],
new_planet = cls(name=planet_data["name"],

planets_response = []
for planet in planets:
planets_response.append(planet.to_dict())
return jsonify(planets_response)

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

whoops, forgot your status code

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants