Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Poor implementation of converting a range of axes to a range of servos #46

Open
vertigra opened this issue Oct 4, 2023 · 0 comments
Open
Assignees
Labels
invalid This doesn't seem right

Comments

@vertigra
Copy link
Contributor

vertigra commented Oct 4, 2023

in extension:
XpadControl.Interfaces.AdamActionsMethodsDependencies.ToServoRange(this float gamepadRangeValue, int zeroPosition)

  1. Add test
  2. Change implementation to the calculated range
    For example (???):
    zeroPosition = 17
    negativeRange = -100 -17
    negativeRangeValue = negativeRange /zeroPosition

if the value on the axis decreases, the change in the value in this case will be equal to negativeRangeValue

@vertigra vertigra self-assigned this Oct 4, 2023
@vertigra vertigra added bug Something isn't working invalid This doesn't seem right and removed bug Something isn't working labels Oct 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
invalid This doesn't seem right
Projects
None yet
Development

No branches or pull requests

1 participant