Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

templateName ignored when subclassing TableRow #11

Closed
leepfrog opened this issue Jan 1, 2013 · 1 comment
Closed

templateName ignored when subclassing TableRow #11

leepfrog opened this issue Jan 1, 2013 · 1 comment
Assignees
@ppong

Comments

@leepfrog
Copy link
Contributor

leepfrog commented Jan 1, 2013

I have a customized TableRow template that I want to use. I tried to subclass Ember.Table.TableRow to point to the new template and set tableRowClass on my TableController to point to my TableRow subclass. I can confirm that it's using the TableRow subclass, but for whatever reason, the templateName override is ignored.
@ghost ghost assigned ppong Jan 1, 2013
@ppong
Copy link
Contributor

ppong commented Mar 3, 2013

@leepfrog fixed in master let me know if this is still a problem. I rename the field to tableRowViewClass in the controller

@ppong ppong closed this as completed Mar 3, 2013
ppong pushed a commit that referenced this issue Mar 3, 2013
Fix for issue #11 and #23 regarding table row view class
7c1fa28
Gaurav0 pushed a commit to Gaurav0/ember-table that referenced this issue Oct 13, 2015
@li-qiang
Merge pull request Addepar#11 from li-qiang/add_internal_columns
8682316 
add grouping column and add internal columns
billy-addepar added a commit that referenced this issue Sep 15, 2017
@billy-addepar
Fix lint errors (#11)
95dd768
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ppong ppong

Labels
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@leepfrog @ppong