Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compute Ember.Table.TableCell's templateName from ColumnDefinition #24

Closed
manoharank opened this issue Feb 8, 2013 · 2 comments
Closed

Comments

@manoharank
Copy link

I need to create lot of dummy views (it only has templateName) to customize the table cell markup. It would be great, if the Ember.Table.TableCell's templateName is computed from column definition

// Ember.Table.TableCell
templateName: function() {
  return this.get('column').get('templateName');
}.property('column')
@ppong
Copy link
Contributor

ppong commented Mar 3, 2013

@manoit88 you can specify the tableCellViewClass in the column definition. Hope this helps

@ppong ppong closed this as completed Mar 3, 2013
@manoharank
Copy link
Author

@ppong Yes, i can specify the tableCellViewClass as a string which should be a view name like App.MyCellView, but with this i will end up with too many Ember.View classes in my App namespace. In my case all those View classes will have only templateName.

Yes, even i can specify the tableCellViewClass as a Ember.View class, but is that correct way (It is something like mixing View related stuff in Controller)?. Correct me if i am wrong with this.

Gaurav0 pushed a commit to Gaurav0/ember-table that referenced this issue Oct 13, 2015
…tor-grouped-row

Merge conflact with refactor grouped row
billy-addepar added a commit that referenced this issue Sep 15, 2017
The `tbody` class does not have 100% height. That's why it's not extended to full table height at the  initial rendering. This is the root cause of html-next/vertical-collection#127

The fix is to set the class to 100% height.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

2 participants