Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Notify user about certificate errors #2722

Closed
Revertron opened this issue Apr 26, 2019 · 4 comments
Closed

Notify user about certificate errors #2722

Revertron opened this issue Apr 26, 2019 · 4 comments
Assignees
@Revertron
Labels
Enhancement SSL
Milestone
3.3

Comments

@Revertron
Copy link

The 2 types of certificate issues are added in AdguardTeam/CoreLibs#868 and we have the opportunity to notify user if there is a problem with certificates on some domain or some application is not trusting our certificate.
The user can disable HTTPS-filtering for that app or try to add server's certificate to user store.
@ghost
Copy link

ghost commented May 11, 2019

I'm showing interest in this as I was about to raise this issue.
From Magisk 17 there has been issues with loss of root which was meant to be getting fixed in 19.2, however yesterday I lost root again, and in turn was not notified by AG of the certificate issue.

@ameshkov ameshkov added this to the 3.2 milestone May 12, 2019
@ameshkov
Copy link
Member

@Revertron assigned to v3.2

@ameshkov ameshkov changed the title Notify user on certificate errors Notify user about certificate errors May 27, 2019
@ameshkov ameshkov modified the milestones: 3.2, 3.3 Jun 10, 2019
@TPS
Copy link
Contributor

TPS commented Oct 5, 2019

pref.notify.on.unknown.ca, right?

@ameshkov
Copy link
Member

ameshkov commented Oct 6, 2019

@TPS yep, that's right

@zzebrum zzebrum closed this as completed Oct 15, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Revertron Revertron

Labels
Enhancement SSL
Projects
None yet
Milestone
3.3
Development

No branches or pull requests
4 participants
@Revertron @TPS @ameshkov @zzebrum