Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update app notification's Learn More causes filter update. #2922

Closed
DitFranXX opened this issue Jul 13, 2019 · 4 comments
Closed

Update app notification's Learn More causes filter update. #2922

DitFranXX opened this issue Jul 13, 2019 · 4 comments

Comments

@DitFranXX
Copy link

DitFranXX commented Jul 13, 2019

Because of new application update design, It triggers filters update which It wasn't and I don't want. (I uses near 100MiB filters). This is little bit questions.

Steps to reproduce

  1. Receive update notification
  2. Extend Update notification
  3. Touch the Learn More
  4. Filters and User.js are updating.

Your environment

  • Adguard version: 3.1.84n
@DitFranXX DitFranXX changed the title Update notification's Learn More causes filter update. Update app notification's Learn More causes filter update. Jul 13, 2019
@ameshkov
Copy link
Member

@DitFranXX any suggestions on what we should do?

@DitFranXX
Copy link
Author

Do not trigger other update things.
I think it's ok because there's check update button on that activity

@ameshkov
Copy link
Member

ameshkov commented Aug 1, 2019

Makes sense.

So when the user opens the Update activity from the "app update is available" notification, we simply should not show other items there and focus on the application update only.

@ameshkov ameshkov modified the milestones: 3.3, 3.4 Aug 1, 2019
@ameshkov
Copy link
Member

ameshkov commented Aug 1, 2019

Assigned to v3.3, it should be relatively easy to implement.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants