Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new rules at the top of user filter? #2962

Closed
superlex opened this issue Jul 25, 2019 · 2 comments
Closed

Add new rules at the top of user filter? #2962

superlex opened this issue Jul 25, 2019 · 2 comments

Comments

@superlex
Copy link

superlex commented Jul 25, 2019

Hi,
when you add a rule to DNS User Filter (by blocking a log entry or simply adding a new rule to user filter), this new rule could be added at the top instead of the bottom, just for user convenience (e.g. if there are many rules).
This behavior could be applied to regular Content Blocking User Filter too, and for other AdGuard products as well.

As an alternative, there could be an option to choose to add the rule at the end or at the top in the dialog window, or in AG settings (e.g., "add new rules at the top").

Steps to reproduce (for example)

  1. open AdGuard -> Settings -> Content Blocking -> User Filter
  2. tap on +
  3. add a rule

Expected behavior

The rule could be added at the top of the list

Actual behavior

The rule is added at the end of the list

Your environment

  • Adguard version: 3.2.98 Beta
@ameshkov
Copy link
Member

Assigned to 3.4 and marked for discussion. Please comment if you have an opinion on this topic.

@superlex
Copy link
Author

Hi, with new AG versions rules are added at the end of the list.
Is it an expected behavior or a regression?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment