Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error while checking updates of userscripts added from the local storage #2997

Closed
ameshkov opened this issue Aug 7, 2019 · 2 comments
Closed
Assignees
Milestone

Comments

@ameshkov
Copy link
Member

ameshkov commented Aug 7, 2019

00:58:43.542 [pool-1-thread-2] WARN  c.a.c.p.u.UserscriptManager - Error downloading userscript: content://com.android.externalstorage.documents/document/primary%3ARuTor.org%20Search%20Filter.js
java.net.MalformedURLException: unknown protocol: content
	at java.net.URL.<init>(URL.java:597) ~[na:0.0]
	at java.net.URL.<init>(URL.java:487) ~[na:0.0]
	at java.net.URL.<init>(URL.java:436) ~[na:0.0]
	at com.adguard.corelibs.proxy.userscript.UserscriptManager.download(UserscriptManager.java:1) ~[na:0.0]
	at com.adguard.corelibs.proxy.userscript.UserscriptManager.isUpdateAvailable0(Native Method) ~[na:0.0]
	at com.adguard.corelibs.proxy.userscript.UserscriptManager.isUpdateAvailable(UserscriptManager.java:2) ~[na:0.0]
	at com.adguard.android.service.a.c.a(UserscriptsServiceImpl.java:18) ~[na:0.0]
	at com.adguard.android.service.job.l$e.a(JobFactoryImpl.java:2) ~[na:0.0]
	at com.adguard.android.service.job.e.run(Unknown Source:2) ~[na:0.0]
	at com.adguard.android.service.job.i.run(AbstractJob.java:2) ~[na:0.0]
	at com.adguard.android.service.job.l$e.run(JobFactoryImpl.java:1) ~[na:0.0]
	at com.adguard.android.service.job.Worker.doWork(Worker.java:10) ~[na:0.0]
	at androidx.work.Worker$1.run(Worker.java:1) ~[na:0.0]
	at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1162) ~[na:0.0]
	at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:636) ~[na:0.0]
	at java.lang.Thread.run(Thread.java:764) ~[na:0.0]
@ameshkov ameshkov added this to the 3.2 milestone Aug 7, 2019
@artemiv4nov artemiv4nov modified the milestones: 3.2, 3.3 Aug 14, 2019
@Chinaski1
Copy link
Member

The same problem occurs on Custom filters

Screenshot:

image

@admitrevskiy
Copy link

Done.

Testing instructions for QA:

  • Reinstall AG
  • Add Extension/Custom filter/DNS Filter from local storage
  • Go to Main screen
  • Tap on Update

Expected result:

  • No errors on update attempt.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants