Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"Add blocking rule" dialog is adding a wrong rule #4685

Closed
3 of 4 tasks
ameshkov opened this issue May 12, 2023 · 0 comments
Closed
3 of 4 tasks

"Add blocking rule" dialog is adding a wrong rule #4685

ameshkov opened this issue May 12, 2023 · 0 comments

Comments

@ameshkov
Copy link
Member

Please answer the following questions for yourself before submitting an issue.

  • I am running the latest version
  • I checked the documentation and found no answer
  • I checked to make sure that this issue has not already been filed

AdGuard version

4.0 Nightly 101

Environment

- OS: Android 12
- Device: Xiaomi

Root access

  • Yes, I have it.

What filters do you have enabled?

No response

What Stealth Mode options do you have enabled?

No response

Issue Details

Steps to reproduce:

  1. Open "Recent activity"
  2. Find a request of type "HTTPS Tunnel" or "Connection"
  3. Uncheck "Apply only for package name" checkbox
  4. Then check it again.

Expected Behavior

On step 3 you should have a simple rule looking like this: ||example.org^
On step 4 you should have a rule with $app modifier only: ||example.org^$app=packagename

IMPORTANT: $domain modifier can only be added if a request has Referrer URL. If this field is missing, there should be no $domain modifier.

Actual Behavior

On step 3 the rule has $domain modifier which makes zero sense for these requests: ||example.org^$domain=example.org
On step 4 the rule has both $domain and $app modifiers: ||example.org^$app=packagename,domain=example.org

Screenshots

Screenshot 1:

telegram-cloud-photo-size-4-5978803035805170790-y

Additional Information

No response

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants