Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Memory leakage and CPU overkill #5173

Open
4 tasks done
GerhardSauer opened this issue Jul 12, 2024 · 16 comments
Open
4 tasks done

Memory leakage and CPU overkill #5173

GerhardSauer opened this issue Jul 12, 2024 · 16 comments

Comments

@GerhardSauer
Copy link

Please answer the following questions for yourself before submitting an issue

  • Filters were updated before reproducing an issue
  • I checked the knowledge base and found no answer
  • I checked to make sure that this issue has not already been filed

AdGuard version

7.17.4709.0

Browser version

Edge 126.0.2592.87

OS version

Windows 11 23H2 Build 22631.3737

Traffic filtering

  • yes, I do

Ad Blocking

No response

Privacy

No response

Social

No response

Annoyances

No response

Security

No response

Other

No response

Language-specific

No response

Which DNS server do you use?

DNS protection disabled

DNS protocol

Regular

Custom DNS

No response

What Stealth Mode options do you have enabled?

No response

Support ticket ID

No response

Issue Details

Steps to reproduce:

  1. use the following filter rules and set exceptions where needed:
    |http$subdocument
    |http$third-party,script,object,media,websocket,xmlhttprequest
  2. close and re-open filtering log every day
  3. keep the machine running

Expected Behavior

no memory leak or CPU overkill

Actual Behavior

memory leakage and CPU overkill

Screenshots

Screenshot 1

image

image

Additional Information

Machine is currently running 12 days.
CPU overkill stopped, when I closed the filtering log.
The CPU overkill happened today for the first time.

I reported already in here as well (AdguardSvc.exe is using 4.5GB of RAM #5016 )
Version 7.18 is not released as msi installer yet.

@Aydinv13
Copy link

@GerhardSauer hello, could you try a new build.

@GerhardSauer
Copy link
Author

Ok, I installed the new version and will come back with results after some days.

@Aydinv13
Copy link

@GerhardSauer how is it going?

@GerhardSauer
Copy link
Author

GerhardSauer commented Jul 24, 2024

@GerhardSauer how is it going?
I had to restart the machine several times, thats why I'm writing now.
Currently 5 days uptime.
image

Definitively better, but still growing. The CPU extreme usage did not happen so far.

@Aydinv13
Copy link

Could you please grab the Debugs logs for us:

  1. Collect the debug log as it's explained here.
  2. Remember the exact time when the issue was reproduced. We will need it to find the corresponding records in the log file.
  3. Send the archive to devteam@adguard.com and mention this issue number(5173) in the subject.

@GerhardSauer
Copy link
Author

GerhardSauer commented Jul 29, 2024

email with logs is sent. (containing CPU issues, it occurs with the provided version as well)
after 10 days, service is again at 7.5 GB commit size memory.
In case, I have a memory dump as well.

relevant log time is 29.07.2024 between 21:24:20 ~ 21:24:45 CEST.

@GerhardSauer
Copy link
Author

GerhardSauer commented Aug 9, 2024 via email

@vankos
Copy link

vankos commented Aug 20, 2024

Hi! We found a few potential places that could be causing the leakage. Could you please try this test build and let us know if the problem persists?
https://uploads.adguard.org/AdGuard-v7.19.4799.4.exe

@GerhardSauer
Copy link
Author

Hi! We found a few potential places that could be causing the leakage. Could you please try this test build and let us know if the problem persists? https://uploads.adguard.org/AdGuard-v7.19.4799.4.exe

yes, i will test, thank you.

@GerhardSauer
Copy link
Author

4 days runtime, 3,7 gb commit size
CPU overkill did not happen so far.

@GerhardSauer
Copy link
Author

GerhardSauer commented Aug 30, 2024

what ever you did, made it worse. @vankos
7 days 17 hours runtime
commit size over 74 GB
image

@vankos
Copy link

vankos commented Sep 2, 2024

Hello, @GerhardSauer,

We need more information to resolve the issue. I have sent instructions to the email you used to send us the dump files, guiding you on how to collect additional data.

@GerhardSauer
Copy link
Author

Profiling is running. I will get back to you as soon as the commit size is bigger.

@vankos
Copy link

vankos commented Sep 6, 2024

@GerhardSauer, we received the snapshots, thanks. I see that the leak is non-linear. Could you tell me, if you recall, if you started doing something differently around 8:00 - 10:00 UTC? Maybe you began adding rules, watching videos, or working with the filtering log etc?

Can you observe if memory consumption still grows if you don’t open the filtering log? (It’s the main suspect for now.)

Also, could you please send the logs for the period when you recorded snapshots to the same email? (You can just send the entire folder: C:\ProgramData\Adguard\Logs\)

@GerhardSauer
Copy link
Author

@vankos , I have uploaded the logs to the same share I sent you in the last email.
I will monitor the memory size the next days without opening the filtering log (currently 2,6GB).

regarding the timing, I can not exactly remember what I did during that time frame. But I did not add much rules the last days.

@GerhardSauer
Copy link
Author

@vankos 3 days later, the commit size is still 2,69 GB. So main increases are related to the filtering log. As I did not write down the exact number the last time, the maximum possible increase is 90 MB or less.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants