Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Applying $removeparam to POST requests #1573

Closed
3 tasks done
Chinaski1 opened this issue Dec 20, 2021 · 0 comments
Closed
3 tasks done

Applying $removeparam to POST requests #1573

Chinaski1 opened this issue Dec 20, 2021 · 0 comments

Comments

@Chinaski1
Copy link
Member

@techIndia-hacker commented on Fri Dec 17 2021

Prerequisites

Please answer the following questions for yourself before submitting an issue. YOU MAY DELETE THE PREREQUISITES SECTION.

  • I am running the latest version
  • I checked the documentation and found no answer
  • I checked to make sure that this issue has not already been filed

Issue Details

  • AdGuard version:
    • v3 6.5
  • Filtering mode:
    • Local Vpn
  • Device:
    • Oneplus 7t
  • Operating system and version:
    • Android 11
  • Root access:
    • Yes

Expected Behavior

$removeparam should remove given parameters from specified domain URL

Actual Behavior

NO changes in the URL is observed in https post reqs

Screenshots

So the ookla speedtest app sends sensitive data line IMEI no. device fingerprint, phone tower area code etc to their servers. I want to block this by stripping off the tracking parameters from the URL. The rule I created is this:- ||speedtest.net^$removeparam=/^(fingerprint|build_id|imei)=/ But it doesn't work. The URL is unmodified as displayed in filtering logs. @ameshkov said that adguard can only modify document type https data in POST reqs, and will be improved later

Request to please fix this as soon as possible

Additional Information

Text me as "Ayan_c99" in telegram for screenshots. Although @ameshkov has all the info


@ameshkov commented on Mon Dec 20 2021

Applying $removeparam to POST requests is technically possible, but might be dangerous.

This issue should be moved to the CoreLibs repo and triaged there.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants