Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rules with $all modifier do not work in some cases #1590

Closed
AdamWr opened this issue Jan 30, 2022 · 4 comments
Closed

Rules with $all modifier do not work in some cases #1590

AdamWr opened this issue Jan 30, 2022 · 4 comments

Comments

@AdamWr
Copy link
Member

AdamWr commented Jan 30, 2022

Maybe related to this - #1531

Steps to reproduce

  1. Add this rule:
||iana.org^$all
  1. Go to - https://www.iana.org/

Expected behavior

There should be a message that website was blocked.

Actual behavior

Main document is not blocked, but requests are blocked.

Screenshot

image


On https://example.org/ it works fine.

||example.org^$all
Screenshot

image

AdGuard for Windows version 7.9 nightly 7 (build 3802, CL 1.9.20)

@sxgunchenko
Copy link

@AdamWr are you sure that the request is matched by the rule? Could you please reproduce it and check if the request to iana.org bypasses filtering for some reason?

@AdamWr
Copy link
Member Author

AdamWr commented Feb 1, 2022

I can't reproduce this issue on iana.org with latest nightly build (7.9 nightly 8 (build 3812, CL 1.9.20)).

According to my screenshot from first post, requests were matched by rule:
image

But I still can reproduce it on another websites like:
https://lenta.ru/
or
https://cdaction.pl/

Rules:

||lenta.ru^$all
||cdaction.pl^$all

image

image

@AdamWr
Copy link
Member Author

AdamWr commented Feb 1, 2022

Okay, I think that I found a culprit of this issue.
It looks like that issue occurs when this filter list is added to filters - https://hole.cert.pl/domains/domains_adblock.txt

@krystian3w
Copy link

I recomended change ^ to ^$all for better support strict-block prompts.

If this need revert on NASK level then try write on wykop on by mail.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants