False-positive on a rule that targets "chrome-extension://${id}"

[ameshkov]

@@||evernote.com^$domain=pioclpoplcdbaefihamjohnefbikjilc

[scripthunter7]

@ameshkov We already have a basic domain validator in AGTree

I recommend improving this utility in the following aspects (new methods):

• validation of domains without wildcards (like wildcard TLD) and check known TLDs
• add method for IPs

We may can import known TLDs to a Set from here

[ameshkov]

I actually specifically don't use a normal validation, it's okay to check invalid domain names too as the tool then will suggest to remove them.

We just need to exclude some things like IP addresses when it does not make sense to check them.

[Alex-302]

IP addresses when it does not make sense to check them

at least ping check can be performed. No response = dead.
Also response can be checked:

curl -I -s -X GET http://45.141.56.28/ | grep -i "HTTP/1.1"
=> HTTP/1.1 301 Moved Permanently / 302. But not HTTP/1.1 403 Forbidden.

[ameshkov]

curl -I -s -X GET http://45.141.56.28/ | grep -i "HTTP/1.1"
=> HTTP/1.1 301 Moved Permanently / 302. But not HTTP/1.1 403 Forbidden.

There're more cases than this one.

First of all, there could be $network rules that can be for different ports/protocols.
Also, even when we deal with basic rules, it could be HTTPS like https://1.1.1.1.

But not HTTP/1.1 403 Forbidden

This is a working IP address, what's wrong with it.
It could be answering 403 to one request and respond with 200 OK to a different one for instance.