Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow sharp comment in exact domain name rules #196

Closed
sfionov opened this issue Jun 27, 2023 · 0 comments
Closed

Allow sharp comment in exact domain name rules #196

sfionov opened this issue Jun 27, 2023 · 0 comments
Assignees
@grumaxxx
Labels
Priority: P4 Resolution: Fixed Status: Closed Version: DnsLibs v2.3

Comments

@sfionov
Copy link
Member

sfionov commented Jun 27, 2023

Currently sharp comments are only allowed inside empty string and hosts rules.

We may allow them also in exact domain name rules.

To synchronize with AdGuard DNS behaviour
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@grumaxxx grumaxxx

Labels
Priority: P4 Resolution: Fixed Status: Closed Version: DnsLibs v2.3
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@sfionov @adguard-bot @ngorskikh @grumaxxx