Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix googletagservices-gpt — setPrivacySettings() #344

Closed
AdamWr opened this issue Jul 31, 2023 · 0 comments
Closed

Fix googletagservices-gpt — setPrivacySettings() #344

AdamWr opened this issue Jul 31, 2023 · 0 comments

Comments

@AdamWr
Copy link
Member

AdamWr commented Jul 31, 2023

It seems that googletagservices-gpt lack of setPrivacySettings method and due to this, it breaks this website - https://heycar.co.uk/

Steps to reproduce:

  1. Add this rule:
||securepubads.g.doubleclick.net/tag/js/gpt.js$script,redirect=googletagservices-gpt,domain=heycar.co.uk,important
  1. Go to - https://heycar.co.uk/

Website is broken.

Screenshot

image

Adding setPrivacySettings: noopThis to pubAdsService:

const pubAdsService = {
addEventListener,
removeEventListener,
clear: noopFunc,
clearCategoryExclusions: noopThis,
clearTagForChildDirectedTreatment: noopThis,
clearTargeting(k) {
if (k === undefined) {
gTargeting.clear();
} else {
gTargeting.delete(k);
}
},
collapseEmptyDivs: noopFunc,
defineOutOfPagePassback() { return new PassbackSlot(); },
definePassback() { return new PassbackSlot(); },
disableInitialLoad: noopFunc,
display: noopFunc,
enableAsyncRendering: noopFunc,
enableLazyLoad: noopFunc,
enableSingleRequest: noopFunc,
enableSyncRendering: noopFunc,
enableVideoAds: noopFunc,
get: noopNull,
getAttributeKeys: noopArray,
getTargeting: noopArray,
getTargetingKeys: noopArray,
getSlots: noopArray,
isInitialLoadDisabled: trueFunc,
refresh: noopFunc,
set: noopThis,
setCategoryExclusion: noopThis,
setCentering: noopFunc,
setCookieOptions: noopThis,
setForceSafeFrame: noopThis,
setLocation: noopThis,
setPublisherProvidedId: noopThis,
setRequestNonPersonalizedAds: noopThis,
setSafeFrameConfig: noopThis,
setTagForChildDirectedTreatment: noopThis,
setTargeting: noopThis,
setVideoContent: noopThis,
updateCorrelator: noopFunc,
};

should fixes it.

@slavaleleka slavaleleka added the bug Something isn't working label Nov 2, 2023
@adguard-bot adguard-bot assigned slavaleleka and unassigned maximtop Nov 2, 2023
@adguard-bot adguard-bot changed the title Fix 'googletagservices-gpt' — setPrivacySettings Fix googletagservices-gpt — setPrivacySettings Nov 2, 2023
@adguard-bot adguard-bot changed the title Fix googletagservices-gpt — setPrivacySettings Fix googletagservices-gpt — setPrivacySettings() Nov 22, 2023
adguard pushed a commit that referenced this issue Nov 23, 2023
Squashed commit of the following:

commit 953106b
Merge: 9244d6d 66f6727
Author: Adam Wróblewski <adam@adguard.com>
Date:   Wed Nov 22 17:04:18 2023 +0100

    Merge branch 'master' into fix/AG-24422

commit 9244d6d
Author: Adam Wróblewski <adam@adguard.com>
Date:   Tue Nov 21 11:05:18 2023 +0100

    Add setPrivacySettings method to googletagservices-gpt
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants