Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Get rid of github.com/jessevdk/go-flags dependency #182

Closed
EugeneOne1 opened this issue Oct 21, 2021 · 2 comments
Closed

Get rid of github.com/jessevdk/go-flags dependency #182

EugeneOne1 opened this issue Oct 21, 2021 · 2 comments
Assignees
@Mizzick
Labels
enhancement New feature or request

Comments

@EugeneOne1
Copy link
Member

EugeneOne1 commented Oct 21, 2021 •
edited
Loading

Currently, we're using github.com/jessevdk/go-flags module to handle configurable options in CLI tool but it provides some notable restrictions and design issues. For example, in #170 which adds the .yaml configuration file support we've came across the inability to properly combine the parsed options' values with values from the file.

Moreover, the functionality provided by go-flags doesn't actually justify abandoning of flag from standard library. Since we strive to keep unnecessary dependencies to a minimum, the one should be removed.
@EugeneOne1 EugeneOne1 added the enhancement New feature or request label Oct 21, 2021
@ainar-g ainar-g mentioned this issue Oct 27, 2021
Closed
@ainar-g
Copy link
Contributor

ainar-g commented Oct 27, 2021

@Potterli20, see https://github.com/AdguardTeam/dnsproxy/blob/master/config.yaml.dist for an example.

Also, please keep questions not relevant to the subject to a minimum. Thanks.

@Mizzick
Copy link
Contributor

Mizzick commented Sep 16, 2024

Fixed in v0.73.2.

@Mizzick Mizzick closed this as completed Sep 16, 2024
cyformatician referenced this issue in openwrt/packages Sep 21, 2024
@1715173329
dnsproxy: migrate old options
67b79fb 
Migrate "all_servers" and "fastest_addr" to new option "upstream_mode".

Fixes: d0823a8 ("dnsproxy: Update to 0.73.2")
Signed-off-by: Tianling Shen <cnsztl@immortalwrt.org>
@cyformatician cyformatician mentioned this issue Sep 22, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Mizzick Mizzick

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@ainar-g @Mizzick @EugeneOne1