From 6ec30c63eb575071667e38c15eb2654aa0ac236d Mon Sep 17 00:00:00 2001 From: FosRexx Date: Thu, 18 Apr 2024 13:39:48 +0545 Subject: [PATCH] Fix spam error message when setting energy_performance_preference The 'intel_pstate' driver does not allow the EPP to be set to anything but 'performance', previously auto-cpufreq tried to set this to 'balance-performance' which caused a spam of write error messages in journalctl and also the 'balance-performance' preference was ignored. This commit just changes the 'balance-performance' preference to 'performance'. --- auto_cpufreq/core.py | 25 ++++++++++++------------- 1 file changed, 12 insertions(+), 13 deletions(-) diff --git a/auto_cpufreq/core.py b/auto_cpufreq/core.py index 0f093566..a7fdd1b7 100755 --- a/auto_cpufreq/core.py +++ b/auto_cpufreq/core.py @@ -122,14 +122,14 @@ def set_override(override): # Current work-around for Pop!_OS where symlink causes permission issues print("[!] Warning: Cannot get distro name") if os.path.exists("/etc/pop-os/os-release"): - # Check if using a Snap + # Check if using a Snap if os.getenv("PKG_MARKER") == "SNAP": - print("[!] Snap install on PopOS detected, you must manually run the following" - " commands in another terminal:\n") + print("[!] Snap install on PopOS detected, you must manually run the following" + " commands in another terminal:\n") print("[!] Backup the /etc/os-release file:") - print("sudo mv /etc/os-release /etc/os-release-backup\n") + print("sudo mv /etc/os-release /etc/os-release-backup\n") print("[!] Create hardlink to /etc/os-release:") - print("sudo ln /etc/pop-os/os-release /etc/os-release\n") + print("sudo ln /etc/pop-os/os-release /etc/os-release\n") print("[!] Aborting. Restart auto-cpufreq when you created the hardlink") sys.exit(1) else: @@ -182,7 +182,7 @@ def check_for_update(): print("Error fetching recent release!") if message is not None and message.startswith("API rate limit exceeded"): print("GitHub Rate limit exceeded. Please try again later within 1 hour or use different network/VPN.") - else: + else: print("Unexpected status code:", response.status_code) return False except (requests.exceptions.ConnectionError, requests.exceptions.Timeout, @@ -215,8 +215,8 @@ def check_for_update(): # Handle the case where "tag_name" key doesn't exist print("Malformed Released data!\nReinstall manually or Open an issue on GitHub for help!") - - + + def new_update(custom_dir): os.chdir(custom_dir) print(f"Cloning the latest release to {custom_dir}") @@ -247,7 +247,7 @@ def get_formatted_version(): literal_version = get_literal_version("auto-cpufreq") splitted_version = literal_version.split("+") formatted_version = splitted_version[0] - + if len(splitted_version) > 1: formatted_version += " (git: " + splitted_version[1] + ")" @@ -571,7 +571,7 @@ def countdown(s): os.environ["TERM"] = "xterm" print("\t\t\"auto-cpufreq\" is about to refresh ", end = "") - + # empty log file if size is larger then 10mb if auto_cpufreq_stats_file is not None: log_size = os.path.getsize(auto_cpufreq_stats_path) @@ -942,8 +942,8 @@ def set_performance(): run(f"cpufreqctl.auto-cpufreq --epp --set={epp}", shell=True) print(f'Setting to use: "{epp}" EPP') else: - run("cpufreqctl.auto-cpufreq --epp --set=balance_performance", shell=True) - print('Setting to use: "balance_performance" EPP') + run("cpufreqctl.auto-cpufreq --epp --set=performance", shell=True) + print('Setting to use: "performance" EPP') # set frequencies set_frequencies() @@ -1382,4 +1382,3 @@ def not_running_daemon_check(): elif os.getenv("PKG_MARKER") == "SNAP" and dcheck == "disabled": daemon_not_running_msg() exit(1) -