-
-
Notifications
You must be signed in to change notification settings - Fork 280
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Issue #698: Add --fullcharge flag to set battery thresholds to max #719
base: master
Are you sure you want to change the base?
Issue #698: Add --fullcharge flag to set battery thresholds to max #719
Conversation
…llcharge_thresholds()
Love it! Besides this being an useful feature that I will also use. It's great to hear this is your very first contribution, after the changes are merged you'll be credited for your work as part of the upcoming release. In PR description instead of "This pull request is for #698" I'd rephrase it it "This pull request From code POV, it LGTM, and I tested the changes and they work as intended. Only request I have is that you also update the README and since this is a new flag add it under auto-cpufreq modes and options section. Also it's a good idea to rephrase: "Use But then I'd also reference "Use instead of: "Use |
I've also noticed something weird and potentially very concerning/serious bug. After I set following as part of my auto-cpufreq.conf file to test this PR:
and then using My battery would charge to 100%, but after reboot I noticed that even after commenting out battery threshold section as part of config file, i.e:
My battery would not charge to 100% anymore, i.e:
The way I fixed this problem was by setting config file to:
Then used fullcharge flag:
and after disabling back threshold settings in config file, i.e:
Battery would charge back to 100%. So in this way, using |
Interesting, I don't think I had this issue, but I'll try to reproduce it. Maybe it has something to do with reloading the config file on boot. I think a better way to handle this would be to make sure that |
This pull request closes Issue #698. It adds a
--fullcharge
flag to the auto-cpufreq command. For thethinkpad
,ideapad_acpi
, andideapad_laptop
interfaces, this sets the charge thresholds to 98 and 99 for start and end respectively to allow for a full charge if you are using very low thresholds for battery longevity. The command only runs if default thresholds are set in a config which then will be set back on the next reboot of the laptop.ps. This is one of my first very first contributions to any open source project, but it's something that I was looking for in a piece of software that I rely on daily. (without auto-cpufreq I wouldn't be able to use my laptop off of a charger at all so thank you for creating this lol) Any feedback about anything being wrong, "unsafe", missing, or things I could improve would be greatly appreciated.