Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] Tray-Icon for Status-Info #87

Closed
schinfo opened this issue Aug 8, 2020 · 29 comments
Closed

[Feature] Tray-Icon for Status-Info #87

schinfo opened this issue Aug 8, 2020 · 29 comments
Assignees
Labels
feature feature requests

Comments

@schinfo
Copy link

schinfo commented Aug 8, 2020

Can you add a tray icon (red / green) so that the status (active / inactive) of auto-cpufreq is visible.

@Red-Eyed
Copy link
Contributor

Red-Eyed commented Aug 8, 2020

@AdnanHodzic I could help with this, maybe even implement. Had experience with python app indicator

@Red-Eyed
Copy link
Contributor

Red-Eyed commented Aug 8, 2020

@AdnanHodzic could you please label issues by category and priority?

@schinfo
Copy link
Author

schinfo commented Aug 8, 2020

Only you as the owner can set labels in GitHub ;-)

@AdnanHodzic
Copy link
Owner

@AdnanHodzic I could help with this, maybe even implement. Had experience with python app indicator

Sure, sounds like a nice idea.

Only you as the owner can set labels in GitHub ;-)

I just sent @Red-Eyed an invite to be a collaborator, with that status he'll be able to do these things :)

@Red-Eyed Red-Eyed added the feature feature requests label Aug 9, 2020
@Red-Eyed Red-Eyed self-assigned this Aug 9, 2020
@Kwaadpepper
Copy link

Kwaadpepper commented Aug 14, 2020

If you do not want to reinvent the wheel there is this tool
https://github.com/konkor/cpufreq

It does not do the automatic job of https://github.com/AdnanHodzic/auto-cpufreq, so both are working well together

It provides a nice icon with info
Capture d’écran de 2020-08-14 09-29-12

@schinfo
Copy link
Author

schinfo commented Aug 14, 2020

cpufreq maybe a very good tool, but the tray-icon doesn't work at Cinnamon

@yochananmarqos
Copy link
Contributor

@Kwaadpepper cpufreq conflicts with auto-cpufreq as they both install the same cpufreqctl binary.

Compare cpufreq's cpufreqctl and auto-cpufreq's cpufreqctl.sh.

@AdnanHodzic
Copy link
Owner

AdnanHodzic commented Dec 6, 2020

During install auto-cpufreq will take a backup of original cpufreqctl if it detects it and will use its own version which has slight improvements over the original. It will also restore the original cpufreqctl if auto-cpufreq is removed.

@Kwaadpepper cpufreq conflicts with auto-cpufreq as they both install the same cpufreqctl binary.

So this is not necessary true as auto-cpufreq will attempt to resolve any conflicts.

@yochananmarqos
Copy link
Contributor

@AdnanHodzic Ah, I see. That will have to be manually dealt with in the AUR package, see my install file. I've let the AUR maintainers know.

@AdnanHodzic
Copy link
Owner

AdnanHodzic commented Dec 6, 2020

@AdnanHodzic Ah, I see. That will have to be manually dealt with in the AUR package, see my install file. I've let the AUR maintainers know.

Cool thanks. I think it would be the best if AUR install file did the same thing auto-cpufreq is trying to do if cpufreqctl is detected, but let's see if @crian has something against this.

@crian
Copy link

crian commented Dec 6, 2020

@AdnanHodzic Ah, I see. That will have to be manually dealt with in the AUR package, see my install file. I've let the AUR maintainers know.

Cool thanks. I think it would be the best if AUR install file did the same thing auto-cpufreq is trying to do if cpufreqctl is detected, but let's see if @crian has something against this.

I'm fine with this. Currently updating the AUR pkg.

@AdnanHodzic
Copy link
Owner

AdnanHodzic commented Dec 6, 2020

@AdnanHodzic Ah, I see. That will have to be manually dealt with in the AUR package, see my install file. I've let the AUR maintainers know.

Cool thanks. I think it would be the best if AUR install file did the same thing auto-cpufreq is trying to do if cpufreqctl is detected, but let's see if @crian has something against this.

I'm fine with this. Currently updating the AUR pkg.

Nice, thanks. Let me know once this has been done, so I can close part of this discussion and I believe same thing is with #133.

@crian
Copy link

crian commented Dec 6, 2020

@AdnanHodzic Ah, I see. That will have to be manually dealt with in the AUR package, see my install file. I've let the AUR maintainers know.

Cool thanks. I think it would be the best if AUR install file did the same thing auto-cpufreq is trying to do if cpufreqctl is detected, but let's see if @crian has something against this.

I'm fine with this. Currently updating the AUR pkg.

Nice, thanks. Let me know once this has been done, so I can close part of this discussion and I believe same thing is with #133.

Done https://aur.archlinux.org/cgit/aur.git/commit/?h=auto-cpufreq-git&id=ff0101f0f6552eb085ede88f132d9cb1677f72f1

@AdnanHodzic
Copy link
Owner

@crian awesome, thanks!

@yochananmarqos and everybody else who had problems with cpufreqctl AUR conflict, if the problem persist please open a new issue as it got out of scope from the original request. Thanks

@yochananmarqos
Copy link
Contributor

yochananmarqos commented Dec 7, 2020

@AdnanHodzic: Really? Thanks.

Thanks to our contributors for this release!

@crian

@AdnanHodzic
Copy link
Owner

@AdnanHodzic: Really? Thanks.

Thanks to our contributors for this release!
@crian

I like to give people credit for their work. Even if it's as simple as creating new version of AUR package which fixes a bug or 2.

@crian
Copy link

crian commented Dec 7, 2020

@AdnanHodzic: Really? Thanks.

Thanks to our contributors for this release!
@crian

I like to give people credit for their work. Even if it's as simple as creating new version of AUR package which fixes a bug or 2.

You should give the credit to @yochananmarqos as he fixed it.

@AdnanHodzic
Copy link
Owner

@crian thanks for the heads up, I completely missed it. @yochananmarqos sorry about that! Updated 1.5.1 release contributors list.

@AdnanHodzic
Copy link
Owner

After v1.7.0 release release and config/settings file going live. This feature is probably next highest item on my priority list. If anyone wants to give it a try at implementing this feature, I'll make sure to give you credit as part of releases page.

@AdnanHodzic
Copy link
Owner

Since I'm very limited with available time to do this myself, if you or anyone else wants to give it a try in implementing this functionality, please give it a try and contribute to the project and you will be credited for your work as part of future release.

@KAGEYAM4
Copy link

KAGEYAM4 commented Sep 9, 2023

Any update on this , currently if i want to force switch to peformance mode , opening terminal > sudoing > writing password. A tray indicator will be nice to force switch on the fly ( 3 modes - auto, powersave, perforcmace ).

Can i use cpu-freq in meantime ? I am on Arch , installed auto-cpu freq thorugh install script. is there any better tray switching method available ?

@AdnanHodzic
Copy link
Owner

AdnanHodzic commented Sep 9, 2023

If you install auto-cpufreq from changes that are on master branch right now, you'll get a desktop entry "auto-cpufreq" which allow you to easily switch between performance/powersave/default mode using auto-cpufreq GTK GUI app.

These changes will be released soon with upcoming v2.0 release and I'll make a video & update documentation about new functionality.

@KAGEYAM4
Copy link

KAGEYAM4 commented Sep 9, 2023

If you install auto-cpufreq from changes that are on master branch right now, you'll get a desktop entry "auto-cpufreq" which allow you to easily switch between performance/powersave/default mode using auto-cpufreq GTK GUI app.

These changes will be released soon with upcoming v2.0 release and I'll make a video & update documentation about new functionality.

when switching mode using gtk gui , it prompts for password , is there a way to skip it ?

@AdnanHodzic
Copy link
Owner

when switching mode using gtk gui , it prompts for password , is there a way to skip it ?

This was done by design. As that's when actual "sudo" privledges will be required in background.

@shadeyg56 now that I think of it, another idea could to require sudo password when auto-cpufreq GUI is initially started. Altough that's not intuative, since maybe some folks will just run it to see the stats.

@shadeyg56
Copy link
Collaborator

right, at some point the GUI HAS to prompt for root password.

Originally, the app actually did prompt during launch, but we changed it because of exactly what you said. I believe it is fine how it is now.

@KAGEYAM4 because overriding is a root action, it doesn't matter what medium you use, it will always need root somehow. It is quite quick to open up the GUI, select the override and enter your password. Please note that the GUI that is available in master has some known issues that are currently being worked on in another branch, but we hope to merge soon :)

@AdnanHodzic
Copy link
Owner

I believe it is fine how it is now.

It's definitely fine as it is now.

@KAGEYAM4
Copy link

right, at some point the GUI HAS to prompt for root password.

Originally, the app actually did prompt during launch, but we changed it because of exactly what you said. I believe it is fine how it is now.

@KAGEYAM4 because overriding is a root action, it doesn't matter what medium you use, it will always need root somehow. It is quite quick to open up the GUI, select the override and enter your password. Please note that the GUI that is available in master has some known issues that are currently being worked on in another branch, but we hope to merge soon :)

Before this i used Windows and KDE, both had quick way to switch power governor, that's what i was hoping here. ( quick switch using tray option )

But seeing that this project whole purpose is to automate this process, i can see that this change won't be used by many.

@KAGEYAM4
Copy link

Is there some other project which provides tray icon to switch power governor and dosen't confilit with auto-cpufreq ?

Or is there some permissions that i can change to add my user/group to not get prompted for sudo access ?

@AdnanHodzic
Copy link
Owner

With release of v2.0.0 now auto-cpufreq has GUI. Hence, tray can be replicated in GNOME by adding auto-cpufreq to "dash" by right clicking and selecting "pin".

Closing the issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature feature requests
Projects
None yet
Development

No branches or pull requests

8 participants