Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Live Search 4.2.0 compatibility minimum should be 2.4.6, not 2.4.4 #51

Closed
alanbort opened this issue Jun 17, 2024 · 3 comments
Closed

Comments

@alanbort
Copy link

alanbort commented Jun 17, 2024

Issue in ./help/live-search/release-notes.md

LiveSearch 4.2.0 requires webonyx/graphql-php ^15.0 but magento/framework 103.0.5-p8 (magento/product-enterprise-edition 2.4.5-p8) requires webonyx/graphql-php (~14.11.6)

:~/customer/livesearch$ composer require "magento/live-search:4.2.0" --dry-run -W
./composer.json has been updated
Running composer update magento/live-search --with-all-dependencies
Loading composer repositories with package information
In Laminas\DependencyPlugin\DependencyRewriterV2::onPrePoolCreate
Updating dependencies
Your requirements could not be resolved to an installable set of packages.

  Problem 1
    - magento/module-live-search-adapter 4.2.0 requires webonyx/graphql-php ^15.0 -> found webonyx/graphql-php[v15.0.0-alpha.1, ..., v15.12.3] but these were not loaded, likely because it conflicts with another require.
    - magento/live-search 4.2.0 requires magento/module-live-search-adapter 4.2.0 -> satisfiable by magento/module-live-search-adapter[4.2.0].
    - Root composer.json requires magento/live-search 4.2.0 -> satisfiable by magento/live-search[4.2.0].


Installation failed, reverting ./composer.json and ./composer.lock to their original content.

and

:~/customer/livesearch$ composer why-not webonyx/graphql-php ^15.0
magento/framework                  103.0.5-p8 requires webonyx/graphql-php (~14.11.6)
magento/module-graph-ql            100.4.5    requires webonyx/graphql-php (~14.11.5)
magento/product-community-edition  2.4.5-p8   requires webonyx/graphql-php (~14.11.6)
magento/product-enterprise-edition 2.4.5-p8   requires webonyx/graphql-php (~14.11.6)
@erikmarr
Copy link
Contributor

erikmarr commented Aug 6, 2024

@sgonzalezmangana and @posyniak can you confirm that in the LS release notes starting from 4.2.0 we should change the supported version from 2.4.4 and newer to 2.4.6 and newer? https://experienceleague.adobe.com/en/docs/commerce-merchant-services/live-search/release-notes#420

@erikmarr
Copy link
Contributor

@alanbort thank you for letting us know! This issue has now been fixed.

@sgonzalezmangana
Copy link
Contributor

As a general guidance all SaaS services must support Commerce versions as per Commerce livecycle policy https://experienceleague.adobe.com/en/docs/commerce-operations/release/planning/lifecycle-policy

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

No branches or pull requests

3 participants