You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I'm not sure if there's a separate place for proposed changes to the coding standard to go, so I'm opening an issue here.
Expected Behaviour
Class attributes that have specified types should not require a DocBlock. When an attribute already has a type, the DocBlock is providing no new information, and is instead just creating noise - e.g.:
I'm not sure if there's a separate place for proposed changes to the coding standard to go, so I'm opening an issue here.
Expected Behaviour
Class attributes that have specified types should not require a DocBlock. When an attribute already has a type, the DocBlock is providing no new information, and is instead just creating noise - e.g.:
We already have the type information - we don't need the DocBlock to tell us the type.
Actual Behaviour
commerce-php/src/pages/coding-standards/docblock.md
Lines 312 to 331 in 9ba0dc3
No distinction is made for different PHP versions.
Proposed solution
Update documentation to require a type declaration only if the attribute does not have a defined type.
The text was updated successfully, but these errors were encountered: