Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Question: Is the project abandoned, and do you need help? #10

Open
dlebech opened this issue Mar 26, 2024 · 7 comments
Open

Question: Is the project abandoned, and do you need help? #10

dlebech opened this issue Mar 26, 2024 · 7 comments

Comments

@dlebech
Copy link

dlebech commented Mar 26, 2024

Hi @ofpiyush, are you still maintaining this library?

The library is very useful, and I'm not actually missing features, but it is a little difficult to use the library with the latest developments in Pydantic and FastAPI, and it would be nice to either get an official patch with #8 or a more permanent fix/update.

Thank you for this library, and if you need any help with maintenance, let me know.

@ofpiyush
Copy link
Contributor

I don't have an active project using it and I don't work at the company anymore.

Would really appreciate help in maintaining and feedback from active users on PRs. 🙏

@niyeradori can someone at Adori pick it?

@dlebech
Copy link
Author

dlebech commented Mar 26, 2024

Thanks for you quick reply @ofpiyush 🙏

In terms of feedback, that's probably better for another thread, but I can tell you briefly that I'm using a fork with the only change being #8 cherry-picked, and that makes the library usable with the latest updates to fastapi/pydantic.

@ofpiyush
Copy link
Contributor

Yea we should get the changes merged in.

cc: @niyeradori

@yogeshdecodes
Copy link
Member

Hi @dlebech and @ofpiyush
Are the proposed changes in #8 backward compatible?
Additionally, do we need to upgrade the required FastAPI version to 0.100.0 to accommodate the Pydantic v2 changes proposed in #8?

@dlebech
Copy link
Author

dlebech commented Mar 28, 2024

@yogeshdecodes No, I don't think that #8 is backwards compatible and would be a breaking change for this library and should bump the major version... And yes, fastapi >=0.100.0 would then be required and should probably be specified in setup.py file (which it isn't right now).

But we're a bit off topic now 🙂 My question was more about whether anyone is going to take this package forward, or whether I should continue to use my own fork...

@yogeshdecodes
Copy link
Member

@dlebech I wanted to reassure you that the project is not abandoned. In fact, we're using this library in many projects internally at Adori, which speaks to its value and utility within our workflows.

I'm relatively new to managing this project, but I'll be taking on the role of supporting its maintenance going forward. While our current priorities mean that we might not be focusing on introducing new features, we are committed to fixing bugs and ensuring the library remains compatible with the latest versions.

We genuinely appreciate your offer to help with the library's maintenance and any feedback you might have.

@dlebech
Copy link
Author

dlebech commented Mar 29, 2024

@yogeshdecodes that's good to hear! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants