Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Preprocess method #1

Open
songminjae opened this issue Feb 21, 2023 · 1 comment
Open

Preprocess method #1

songminjae opened this issue Feb 21, 2023 · 1 comment

Comments

@songminjae
Copy link

In train.py file, I guess there exists 3 main preprocessing methods.
However, the only one working mehtod is digl.
Are you willing to update the version of "sdrf" and "knn"?

@AdrianArnaiz
Copy link
Owner

Hi!

First, thanks a lot for reaching out and identifying this bug! The last time I used both sdrf and knn prepros, they were working smoothly. Let me run the code again to see if I have any issue with last modifications or versions and I'll get back to you asap :)

However, the main purpose of this repo is to provide the DiffWire code. Therefore, if you are in a hurry, SDRF prepro comes from the original repo and KNN comes from the original PyG version.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants