Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Custom aliases + more currencyies #9

Closed
iSplasher opened this issue May 31, 2024 · 3 comments
Closed

Custom aliases + more currencyies #9

iSplasher opened this issue May 31, 2024 · 3 comments
Labels
help wanted Extra attention is needed

Comments

@iSplasher
Copy link

Hi, would it be possible to add the following things?

  • Load "currencies.json" from a local file. It can just be inside the plugin folder
  • Support aliases. I keep typing EURO or EU and always forget it's EUR. Would be nice if I could add my own aliase to some of the currencies. Or maybe just support fuzzy search on the current ones.

Thanks!

@Advaith3600
Copy link
Owner

Hi, these look like some nice additions—one of the issues with a local currencies.json file will be that it will be outdated and it will be up to the users to update it. Aliasing is an idea that I wanted to do from day one, but always messed up while implementing it.

Could someone help with implementing these functionalities? In the meantime, I will try coming up with a simple approach.

@Steef-Broeder
Copy link

Hi, I would like to try and add something like this. I have little experience with cs and contibuting to open source but I will try this coming week!

@Advaith3600 Advaith3600 linked a pull request Jul 7, 2024 that will close this issue
@Advaith3600 Advaith3600 added the help wanted Extra attention is needed label Jul 7, 2024
@Advaith3600
Copy link
Owner

I have come up with a solution to this issue, please check the following and let me know if it is having any problem or missing any feature. You can read more about the config here

CurrencyConverter-1.2.0-x64.zip
CurrencyConverter-1.2.0-ARM64.zip

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Extra attention is needed
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants