Mask fields when request is string

[rabinshr]

Description
Mask sensitive fields when request is a string. The only times I have managed to see request come in as a string is when Adyen web service user has a missing permission.

Due to the fact that we parse request string into a hash inside of the mask_fields method, the current code doesn't modify the original request and it preserves the original request data without masking any of the fields.

Additionally, while parsing it wasn't symbolising the name which meant, further down we were comparing string with symbols here

Tested scenarios

• screenshot showing request is actually masked even when it is a string
  
• added unit tests to cover request is a string scenario

Fixed issue:

[crrood]

Hi Rabin,

Makes sense to me! Thanks for the PR - approved.

Best,
Colin

[rabinshr]

@wboereboom , any chance you could give this a look?

[rabinshr]

@wboereboom any chance you could have a look at this?

[wboereboom]

Hi @rabinshr,

Thanks for contributing!
I was Out Of Office for a bit, hence my lack of response 😉 .

Looks good to me, so I'm approving and merging!

Kind Regards,
Wouter
Adyen