Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deps: uv sync --all-extras fails due to langchain & python 3.7 #524

Closed
teocns opened this issue Nov 21, 2024 · 3 comments · Fixed by #526
Closed

deps: uv sync --all-extras fails due to langchain & python 3.7 #524

teocns opened this issue Nov 21, 2024 · 3 comments · Fixed by #526

Comments

@teocns
Copy link
Contributor

teocns commented Nov 21, 2024

Issue Description

Command Used:

uv sync --all-extras

Error Encountered:

Using CPython 3.12.2
Creating virtual environment at: .venv
  × No solution found when resolving dependencies:
  ╰─▶ Because the requested Python version (>=3.7) does not satisfy Python>=3.8 and langchain==0.2.14 depends on Python>=3.8.1,<4.0, we can conclude that langchain==0.2.14 cannot
      be used.
      And because agentops[langchain] depends on langchain==0.2.14 and your project requires agentops[langchain], we can conclude that your projects's requirements are unsatisfiable.

      hint: The `requires-python` value (>=3.7) includes Python versions that are not supported by your dependencies (e.g., langchain==0.2.14 only supports >=3.8.1, <4.0). Consider
      using a more restrictive `requires-python` value (like >=3.8.1, <4.0).

Translation

  • langchain==0.2.14 requires Python>=3.8
  • Agentops requires-python >= 3.7 (see pyproject.toml)

Proposal

To require-python >= 3.9 which is actually (these times) the "oldest" supported version across most packages

@teocns teocns changed the title deps: uv sync --all-extras fails due to "python version incompatibility" deps: uv sync --all-extras fails due to langchain package Nov 21, 2024
@teocns
Copy link
Contributor Author

teocns commented Nov 21, 2024

cc @areibman high priority for development, I keep stashing pyproject.toml
Mentioning you because this maybe affects a bit the CI ecosystem as well as distribution.
Enforcing >=3.9 explicitly drops support for <3.9, anything that we should know before merging that upstream?
Can we tell the # of clients depending on <3.9, if any?

@teocns teocns changed the title deps: uv sync --all-extras fails due to langchain package deps: uv sync --all-extras fails due to langchain & python-version 3.7 Nov 21, 2024
@teocns teocns changed the title deps: uv sync --all-extras fails due to langchain & python-version 3.7 deps: uv sync --all-extras fails due to langchain & python 3.7 Nov 21, 2024
@areibman
Copy link
Contributor

Is it possible we only drop support for <3.9 when the agentops[langchain] optional dependency is installed?

Alternatively, given python 3.9 is almost 5 years old, I think it's fair for us to drop it

@teocns
Copy link
Contributor Author

teocns commented Nov 21, 2024

Is it possible we only drop support for <3.9 when the agentops[langchain] optional dependency is installed?

I think it's possible, and it's a good idea 💡
Yet I smell side effects and complications

Alternatively, given python 3.9 is almost 5 years old, I think it's fair for us to drop it

We're dropping support for 3.8 (lower than 3.9)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants