From cb5f043976d33e1c922388d29683c4e72ec81077 Mon Sep 17 00:00:00 2001
From: 0xPatrick <patrick@0xpatrick.dev>
Date: Fri, 28 Jun 2024 12:01:42 -0400
Subject: [PATCH] chore(orchestration): document TODOs with ticket numbers

---
 packages/orchestration/src/exos/chain-account-kit.js           | 2 ++
 .../orchestration/src/exos/cosmos-orchestration-account.js     | 1 +
 packages/orchestration/src/exos/local-chain-facade.js          | 2 ++
 packages/orchestration/src/exos/local-orchestration-account.js | 1 +
 packages/orchestration/src/exos/orchestrator.js                | 2 ++
 packages/orchestration/src/exos/remote-chain-facade.js         | 3 ++-
 6 files changed, 10 insertions(+), 1 deletion(-)

diff --git a/packages/orchestration/src/exos/chain-account-kit.js b/packages/orchestration/src/exos/chain-account-kit.js
index a735afac4699..f4cae4c28673 100644
--- a/packages/orchestration/src/exos/chain-account-kit.js
+++ b/packages/orchestration/src/exos/chain-account-kit.js
@@ -102,10 +102,12 @@ export const prepareChainAccountKit = (zone, { watch, asVow }) =>
           );
         },
         getBalance(_denom) {
+          // TODO https://github.com/Agoric/agoric-sdk/issues/9610
           // UNTIL https://github.com/Agoric/agoric-sdk/issues/9326
           return asVow(() => Fail`not yet implemented`);
         },
         getBalances() {
+          // TODO https://github.com/Agoric/agoric-sdk/issues/9610
           // UNTIL https://github.com/Agoric/agoric-sdk/issues/9326
           return asVow(() => Fail`not yet implemented`);
         },
diff --git a/packages/orchestration/src/exos/cosmos-orchestration-account.js b/packages/orchestration/src/exos/cosmos-orchestration-account.js
index d4e6d4b5f479..53a42671b9e9 100644
--- a/packages/orchestration/src/exos/cosmos-orchestration-account.js
+++ b/packages/orchestration/src/exos/cosmos-orchestration-account.js
@@ -374,6 +374,7 @@ export const prepareCosmosOrchestrationAccountKit = (
           );
         },
         getBalances() {
+          // TODO https://github.com/Agoric/agoric-sdk/issues/9610
           return asVow(() => Fail`not yet implemented`);
         },
         /**
diff --git a/packages/orchestration/src/exos/local-chain-facade.js b/packages/orchestration/src/exos/local-chain-facade.js
index 694ef809224e..5684f7de7690 100644
--- a/packages/orchestration/src/exos/local-chain-facade.js
+++ b/packages/orchestration/src/exos/local-chain-facade.js
@@ -67,8 +67,10 @@ const prepareLocalChainFacadeKit = (
         /** @returns {Vow<PromiseToVow<OrchestrationAccount<ChainInfo>>>} */
         makeAccount() {
           const lcaP = E(localchain).makeAccount();
+          // TODO #9449 fix types
           // @ts-expect-error 'Vow<Guarded<{...}>> is not assignable to type 'Vow<never>'
           return watch(
+            // TODO #9449 fix types
             // @ts-expect-error Property 'getAddress' does not exist on type 'EMethods<Required<Guarded<{ getAddress()...
             allVows([lcaP, E(lcaP).getAddress()]),
             this.facets.makeAccountWatcher,
diff --git a/packages/orchestration/src/exos/local-orchestration-account.js b/packages/orchestration/src/exos/local-orchestration-account.js
index 087430527ef7..0d6660f2a047 100644
--- a/packages/orchestration/src/exos/local-orchestration-account.js
+++ b/packages/orchestration/src/exos/local-orchestration-account.js
@@ -304,6 +304,7 @@ export const prepareLocalOrchestrationAccountKit = (
           );
         },
         getBalances() {
+          // TODO https://github.com/Agoric/agoric-sdk/issues/9610
           return asVow(() => Fail`not yet implemented`);
         },
 
diff --git a/packages/orchestration/src/exos/orchestrator.js b/packages/orchestration/src/exos/orchestrator.js
index 8047085a2ed6..8f1ca88ee75c 100644
--- a/packages/orchestration/src/exos/orchestrator.js
+++ b/packages/orchestration/src/exos/orchestrator.js
@@ -115,12 +115,14 @@ export const prepareOrchestratorKit = (
         /** @type {PromiseToVow<Orchestrator['getChain']>} */
         getChain(name) {
           if (name === 'agoric') {
+            // TODO #9449 fix types
             // @ts-expect-error Type 'Vow<Voidless>' is not assignable to type 'Vow<Chain<any>>'.
             return watch(
               chainHub.getChainInfo('agoric'),
               this.facets.makeLocalChainFacadeWatcher,
             );
           }
+          // TODO #9449 fix types
           // @ts-expect-error Type 'Vow<Voidless>' is not assignable to type 'Vow<Chain<any>>'.
           return watch(
             chainHub.getChainsAndConnection('agoric', name),
diff --git a/packages/orchestration/src/exos/remote-chain-facade.js b/packages/orchestration/src/exos/remote-chain-facade.js
index c9b06e69d1df..b2d7039c5e36 100644
--- a/packages/orchestration/src/exos/remote-chain-facade.js
+++ b/packages/orchestration/src/exos/remote-chain-facade.js
@@ -79,7 +79,8 @@ const prepareRemoteChainFacadeKit = (
 
         /** @returns {Vow<PromiseToVow<OrchestrationAccount<ChainInfo>>>} */
         makeAccount() {
-          // @ts-expect-error 'Vow<Guarded<{...}>> is not assignable to type 'Vow<never>'
+          // TODO #9449 fix types
+          // @ts-expect-error 'Vow<Guarded<{...}>> is not assignable to type 'Vow<never>' #9449
           return asVow(() => {
             const { remoteChainInfo, connectionInfo } = this.state;
             const stakingDenom = remoteChainInfo.stakingTokens?.[0]?.denom;