From d0c6811cf12ffcf506ea0cf0bdb31b56f2e27b13 Mon Sep 17 00:00:00 2001
From: Michael FIG <mfig@agoric.com>
Date: Sun, 7 May 2023 17:14:36 -0600
Subject: [PATCH] test(vats): vat-bank needs MapStore ocap insertion-order
 preservation

---
 packages/vats/test/test-vat-bank.js | 35 +++++++++++++++++++++++++++++
 1 file changed, 35 insertions(+)

diff --git a/packages/vats/test/test-vat-bank.js b/packages/vats/test/test-vat-bank.js
index 977539d11e40..8a1e7f1abf78 100644
--- a/packages/vats/test/test-vat-bank.js
+++ b/packages/vats/test/test-vat-bank.js
@@ -7,6 +7,7 @@ import { fakeVomKit } from './setup-vat-data.js';
 import { E } from '@endo/far';
 import { AmountMath, makeIssuerKit, AssetKind } from '@agoric/ertp';
 import { makeDurableZone } from '@agoric/zone/durable.js';
+import { heapZone } from '@agoric/zone';
 import { subscribeEach } from '@agoric/notifier';
 import { buildRootObject } from '../src/vat-bank.js';
 
@@ -16,6 +17,40 @@ const provideBaggage = key => {
   return zone.mapStore(`${key} baggage`);
 };
 
+test('provideAssetSubscription - MapStore insertion order preserved', async t => {
+  const zones = {
+    durableZone: makeDurableZone(provideBaggage('key order')),
+    heapZone,
+  };
+  for (const [name, zone] of Object.entries(zones)) {
+    const ids = harden(['a', 'b', 'c', 'd', 'e']);
+    const handleToId = new Map(
+      ids.map(id => [zone.exo(`${name} ${id} handle`, undefined, {}), id]),
+    );
+
+    const forwardMap = zone.mapStore(`${name} forward map`);
+    handleToId.forEach((id, h) => forwardMap.init(h, id));
+    const forwardMapIds = [...forwardMap.values()];
+
+    const reverseMap = zone.mapStore(`${name} reverse map`);
+    [...handleToId.entries()]
+      .reverse()
+      .forEach(([h, id]) => reverseMap.init(h, id));
+    const reverseMapIds = [...reverseMap.values()];
+
+    t.deepEqual(
+      forwardMapIds,
+      ids,
+      `${name} forward map insertion order preserved`,
+    );
+    t.deepEqual(
+      reverseMapIds,
+      [...ids].reverse(),
+      `${name} reverse map insertion order preserved`,
+    );
+  }
+});
+
 test('communication', async t => {
   t.plan(32);
   const baggage = provideBaggage('communication');