From baac7bd19d257a546648532fb306cf29cfbdd374 Mon Sep 17 00:00:00 2001 From: Mathieu Hofman Date: Tue, 29 Aug 2023 00:13:27 +0000 Subject: [PATCH 1/4] ci: capture combined integration test results --- .github/workflows/integration.yml | 19 +++++++++++++++++++ 1 file changed, 19 insertions(+) diff --git a/.github/workflows/integration.yml b/.github/workflows/integration.yml index 827424f5b36..33b51339c61 100644 --- a/.github/workflows/integration.yml +++ b/.github/workflows/integration.yml @@ -311,3 +311,22 @@ jobs: timeout-minutes: 4 with: datadog-token: ${{ secrets.DATADOG_API_KEY }} + + integration-test-result: + needs: + - pre_check + - getting-started + - deployment-test + - test-docker-build + if: needs.pre_check.outputs.should_run == 'true' && (success() || failure() || cancelled()) + runs-on: ubuntu-latest + steps: + - name: Check job results + shell: bash + run: | + cat < Date: Tue, 29 Aug 2023 02:16:06 +0000 Subject: [PATCH 2/4] ci: add unlabeled pull_request trigger --- .github/workflows/integration.yml | 1 + .github/workflows/mergify-ready.yml | 1 + 2 files changed, 2 insertions(+) diff --git a/.github/workflows/integration.yml b/.github/workflows/integration.yml index 33b51339c61..3aa3db2550f 100644 --- a/.github/workflows/integration.yml +++ b/.github/workflows/integration.yml @@ -19,6 +19,7 @@ on: - converted_to_draft - ready_for_review - labeled + - unlabeled - auto_merge_enabled - auto_merge_disabled merge_group: diff --git a/.github/workflows/mergify-ready.yml b/.github/workflows/mergify-ready.yml index cbfe20ca0d3..945e9f1da97 100644 --- a/.github/workflows/mergify-ready.yml +++ b/.github/workflows/mergify-ready.yml @@ -9,6 +9,7 @@ on: - converted_to_draft - ready_for_review - labeled + - unlabeled - auto_merge_enabled - auto_merge_disabled merge_group: From 62c774089fb04ac30c67e210e1ec4ee289cd729a Mon Sep 17 00:00:00 2001 From: Mathieu Hofman Date: Tue, 29 Aug 2023 02:34:53 +0000 Subject: [PATCH 3/4] ci: some integration test failures are not fatal --- .github/workflows/integration.yml | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/.github/workflows/integration.yml b/.github/workflows/integration.yml index 3aa3db2550f..4abcbe4cefe 100644 --- a/.github/workflows/integration.yml +++ b/.github/workflows/integration.yml @@ -44,6 +44,9 @@ jobs: fail-fast: false matrix: cli: [link-cli, local-npm] + # Mark a failure of `local-npm` as a successful result + # TODO: remove when `local-npm` job is fixed + continue-on-error: ${{ matrix.cli == 'local-npm' }} timeout-minutes: 40 steps: - uses: actions/checkout@v3 @@ -270,6 +273,8 @@ jobs: strategy: matrix: bootstrap-version: ['test', 'main'] + # Uncomment to mark a failure of the `test` bootstrap job as a successful result + # continue-on-error: ${{ matrix.bootstrap-version == 'test' }} steps: - name: free up disk space run: | From 3e0bc6cc40d6fb22667ace774ba0f2ce5454aec3 Mon Sep 17 00:00:00 2001 From: Mathieu Hofman Date: Tue, 29 Aug 2023 03:06:18 +0000 Subject: [PATCH 4/4] ci(mergify): use integration test combined result --- .mergify.yml | 37 ++++--------------------------------- 1 file changed, 4 insertions(+), 33 deletions(-) diff --git a/.mergify.yml b/.mergify.yml index cc29eaca1b3..0f1a07469e5 100644 --- a/.mergify.yml +++ b/.mergify.yml @@ -5,38 +5,9 @@ queue_rules: - base=master # Require integration tests before merging only - or: - - label=bypass:integration - - check-failure!=Integration tests - - or: - - label=bypass:integration - - check-success=deployment-test - - check-neutral=deployment-test - - check-skipped=deployment-test - - or: - - label=bypass:integration - - check-failure!=test-docker-build (main) - - or: - - label=bypass:integration - - check-skipped=test-docker-build - - check-success=test-docker-build (main) - - check-neutral=test-docker-build (main) - - check-skipped=test-docker-build (main) - - or: - - label=bypass:integration - - check-failure!=getting-started (link-cli) - - or: - - label=bypass:integration - - check-skipped=getting-started - - check-success=getting-started (link-cli) - - check-neutral=getting-started (link-cli) - - check-skipped=getting-started (link-cli) - # FIXME: Enable this section to validate NPM deploys... - #- or: - # - label=bypass:integration - # - check-skipped=getting-started - # - check-success=getting-started (local-npm) - # - check-neutral=getting-started (local-npm) - # - check-skipped=getting-started (local-npm) + - check-success=integration-test-result + - check-neutral=integration-test-result + - check-skipped=integration-test-result pull_request_rules: - name: merge to master @@ -44,7 +15,7 @@ pull_request_rules: - base=master - label=automerge:no-update - or: - - "#commits-behind=0" + - '#commits-behind=0' - label=bypass:linear-history - or: - check-success=wait-integration-pre-checks