Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add FastLP to vbank in initial deployment #10703

Open
dckc opened this issue Dec 16, 2024 · 0 comments · May be fixed by #10709
Open

add FastLP to vbank in initial deployment #10703

dckc opened this issue Dec 16, 2024 · 0 comments · May be fixed by #10709
Labels
enhancement New feature or request

Comments

@dckc
Copy link
Member

dckc commented Dec 16, 2024

What is the Problem Being Solved?

We have discussed adding FastLP to vbank to enable IBC transfer etc. in due course but not initially.
Meanwhile, FastUSDC clients (on master but unreleased) are looking for FastLP balances in .purses of published.wallet.${addr}.current.
When we add FastLP to vbank, the balance updates will no longer go there (the normal cosmos bank module updates are much more efficient; see #3629, #6652, #8564 ). So that would be a breaking change

Description of the Design

Use E(bankManager).addAsset(...) to add FastLP to vbank in the initial fast usdc deployment.

For the cosmos denom: ufastlp
6 decimal places like IST, BLD, USDC, ATOM, etc.

Security Considerations

nothing novel; follows the usual agoric name services architecture to address phishing etc.

those docs should include material on these considerations: #10702

Scaling Considerations

Eliminates a vbank callback to swingset for every Fast USDC balance update at every liquidity provider's address.

Test Plan

Update existing tests to that clients use cosmos bank queries for FastLP.

Upgrade Considerations

Addressing this issue before initial deployment is intended to avoid some major upgrade considerations.

@dckc dckc added the enhancement New feature or request label Dec 16, 2024
@turadg turadg added this to the FU3: multichain integration milestone Dec 16, 2024
@dckc dckc linked a pull request Dec 17, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants
@turadg @dckc and others