Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Price authority updated via governance in Vault Factory #5060

Open
dtribble opened this issue Apr 11, 2022 · 0 comments
Open

Price authority updated via governance in Vault Factory #5060

dtribble opened this issue Apr 11, 2022 · 0 comments
Labels
enhancement New feature or request Inter-protocol Overarching Inter Protocol oracle Related to on-chain oracles. Vaults VaultFactor (née Treasury)

Comments

@dtribble
Copy link
Member

What is the Problem Being Solved?

The vault factory relies on a price authority, but the price authority implementation could change strategy, get updated, have bug fixes, etc. The two contracts could be more decoupled if the price authority for the vault were able to be changed by governance.

Description of the Design

Enable changing the price authority instance. All outstanding queries are only for liquidation; they could just be reissued if the price authority changed.

Security Considerations

Oracles are a complicated, separate system. Enabling them to be upgraded with minimal impact on teh vault provides bettersafety isolation and better upgrade support.

Test Plan

TBD

@dtribble dtribble added enhancement New feature or request Inter-protocol Overarching Inter Protocol oracle Related to on-chain oracles. Vaults VaultFactor (née Treasury) labels Apr 11, 2022
@Tartuffo Tartuffo changed the title Price authority updated via governance in vault Price authority updated via governance in Vault Factory Apr 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request Inter-protocol Overarching Inter Protocol oracle Related to on-chain oracles. Vaults VaultFactor (née Treasury)
Projects
None yet
Development

No branches or pull requests

2 participants