Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reserve collects liquidity held by AMM from creating new pools #5408

Closed
Chris-Hibbert opened this issue May 20, 2022 · 0 comments · Fixed by #5429
Closed

Reserve collects liquidity held by AMM from creating new pools #5408

Chris-Hibbert opened this issue May 20, 2022 · 0 comments · Fixed by #5429
Assignees
Labels
AMM enhancement New feature or request Inter-protocol Overarching Inter Protocol
Milestone

Comments

@Chris-Hibbert
Copy link
Contributor

Chris-Hibbert commented May 20, 2022

What is the Problem Being Solved?

See https://github.com/Agoric/agoric-sdk/pull/5377/files#r877423297

#5377 changed the process for adding new pools to the AMM to enforce a minimum liquidity, and hold the corresponding liquidity tokens for the reserve.

Description of the Design

? How should the reserve receive the funds?

Decision: PUSH

Security Considerations

legibility, bootstrap dependency issues. This needs to be done in a way that is visible and subject to governance, without allowing the process to be subverted.

Test Plan

test deliver of funds. proving security properties is external to the testing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
AMM enhancement New feature or request Inter-protocol Overarching Inter Protocol
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants