Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AMM enforce minimum liquidity by wrapping addPool with a new contract #5634

Closed
Chris-Hibbert opened this issue Jun 21, 2022 · 1 comment
Closed
Assignees
Labels
AMM enhancement New feature or request vaults_triage DO NOT USE

Comments

@Chris-Hibbert
Copy link
Contributor

What is the Problem Being Solved?

When we enforced minimum liquidity inside addPool (#5377)

Description of the Design

  • move addPool() to the creator facet
  • write a new contract that enforces the minimum and transfers liquidity tokens to the reserve

Security Considerations

Simplify the interface and reduce error conditions.
If there's an issue in creating the Reserve pool, the AMM remains in a consistent state.

Test Plan

check for races

@Chris-Hibbert
Copy link
Contributor Author

The AMM was removed in #7074

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
AMM enhancement New feature or request vaults_triage DO NOT USE
Projects
None yet
Development

No branches or pull requests

3 participants