Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

insufficient cost recovery for InstallBundle message handling #6858

Closed
dckc opened this issue Jan 26, 2023 · 1 comment · Fixed by #7290
Closed

insufficient cost recovery for InstallBundle message handling #6858

dckc opened this issue Jan 26, 2023 · 1 comment · Fixed by #7290
Assignees
Labels
bug Something isn't working cosmic-swingset package: cosmic-swingset vaults_triage DO NOT USE
Milestone

Comments

@dckc
Copy link
Member

dckc commented Jan 26, 2023

Describe the bug

The InstallBundle message results in more or less permanent storage of the bundle, but we currently only charge as though it were a large message to be consumed.

func (keeper msgServer) InstallBundle(goCtx context.Context, msg *types.MsgInstallBundle) (*types.MsgInstallBundleResponse, error) {

To Reproduce

IOU some experimental data on current charging rates

Expected behavior

IOU some economic justification of how much is enough. The cost should be subject to governance.

Additional context

The design in #4396 included:

The fees to be charged need to be configurable.

#6049 adds charging admission fees on MsgWalletSpendAction but not on MsgInstallBundle.

cc @michaelfig @JimLarson @kriskowal

@dckc dckc added bug Something isn't working cosmic-swingset package: cosmic-swingset labels Jan 26, 2023
@dckc
Copy link
Member Author

dckc commented Jan 26, 2023

@warner any thoughts on how much is "enough"? Should this be a separate dimension from all these?

	BeansPerInboundTx         = "inboundTx"
	BeansPerBlockComputeLimit = "blockComputeLimit"
	BeansPerMessage           = "message"
	BeansPerMessageByte       = "messageByte"
	BeansPerMinFeeDebit       = "minFeeDebit"
	BeansPerVatCreation       = "vatCreation"
	BeansPerXsnapComputron    = "xsnapComputron"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working cosmic-swingset package: cosmic-swingset vaults_triage DO NOT USE
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants