Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

agops inter auction status fails to handle missing schedule info #7786

Closed
dckc opened this issue May 18, 2023 · 2 comments · Fixed by #7787
Closed

agops inter auction status fails to handle missing schedule info #7786

dckc opened this issue May 18, 2023 · 2 comments · Fixed by #7787
Assignees
Labels
agoric-cli package: agoric-cli auction bug Something isn't working UI

Comments

@dckc
Copy link
Member

dckc commented May 18, 2023

Describe the bug

agops inter auction status fails on unexpected input

To Reproduce

IOU

Expected behavior

If some parts are missing, show the rest.

Platform Environment

I was looking at @otoole-brendan 's screen while he was in some version upgrade-testing container

  • what OS are you using? what version of Node.js?
  • is there anything special/unusual about your platform?
  • what version of the Agoric-SDK are you using? (run git describe --tags --always)

Additional context

liquidation testing

Screenshots

root@be7d8697f9db:/usr/src/agoric-sdk# agops inter bid by-price --price 7.5 --give 75IST --from $GOV1ADDR --keyr^Cg-backend=test
root@be7d8697f9db:/usr/src/agoric-sdk#
root@be7d8697f9db:/usr/src/agoric-sdk# agops inter auction status
(TypeError#1)
TypeError#1: Cannot read properties of null (reading 'absValue')
 at Object.absTime (packages/agoric-cli/src/commands/inter.js:68:44)
 at Command.<anonymous> (packages/agoric-cli/src/commands/inter.js:293:32)
 at async packages/agoric-cli/src/bin-agops.js:78:3
root@be7d8697f9db:/usr/src/agoric-sdk#
root@be7d8697f9db:/usr/src/agoric-sdk#
root@be7d8697f9db:/usr/src/agoric-sdk# agops inter auction status
(TypeError#1)
TypeError#1: Cannot read properties of null (reading 'absValue')
 at Object.absTime (packages/agoric-cli/src/commands/inter.js:68:44)
 at Command.<anonymous> (packages/agoric-cli/src/commands/inter.js:293:32)
 at async packages/agoric-cli/src/bin-agops.js:78:3
@dckc dckc added bug Something isn't working agoric-cli package: agoric-cli UI auction labels May 18, 2023
@dckc
Copy link
Member Author

dckc commented May 18, 2023

Looks like a consequence of e893e0e where some fields of ScheduleNotification became optional.

Oddly, that commit is marked as a refactor, but also marked as closing a bug. Here we see that it's a also breaking change of sorts.

@dckc
Copy link
Member Author

dckc commented May 18, 2023

Here's hoping we can tightly connect the documentation for the types of the data published via RPC along with the snapshots of example data such as test-auctionContract.js.md

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
agoric-cli package: agoric-cli auction bug Something isn't working UI
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant