Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

auction publish all bids to vstorage #7906

Open
Tracked by #7982 ...
Chris-Hibbert opened this issue Jun 9, 2023 · 2 comments
Open
Tracked by #7982 ...

auction publish all bids to vstorage #7906

Chris-Hibbert opened this issue Jun 9, 2023 · 2 comments
Assignees

Comments

@Chris-Hibbert
Copy link
Contributor

What is the Problem Being Solved?

In order to display all the outstanding bids to auction users (#7159), we'll have to start by publishing them.

Description of the Design

Write all the bids to vstorage, indexed by their sequence number.

The Product Spec wants a timestamp, unique identifier, the price or discount bid, the amount of IST available, and the maximum collateral desired. The auction doesn't currently store a timestamp for each bid, this would have to be added. It's apparently okay that this won't be unique.

If we use the unique ID as an identifier in the tree; we only have to update bids as they change.

Security Considerations

This will be public data.

Scaling Considerations

The expectation is that we'll see dozens or hundreds of bids per auction for the near future. We may have to revisit aspects of the design if it gets to 10s of thousands or more.

Test Plan

unit tests for the writing. Plan to have a reader (probably CLI-based) in process to consume the data to validate the info is usable.

@Chris-Hibbert
Copy link
Contributor Author

Current theory is that when a Bid get fulfilled, withdrawn or cancelled, we should delete the vstorage node corresponding to the bid.

@turadg
Copy link
Member

turadg commented Jul 12, 2023

#7618 will allow for deleting nodes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants