Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CI should enforce protobuf generated code is up to date #8131

Closed
mhofman opened this issue Aug 1, 2023 · 1 comment · Fixed by #9656
Closed

CI should enforce protobuf generated code is up to date #8131

mhofman opened this issue Aug 1, 2023 · 1 comment · Fixed by #9656
Assignees
@LuqiPan
Labels
agoric-cosmos bug Something isn't working enhancement New feature or request tooling repo-wide infrastructure

Comments

@mhofman
Copy link
Member

mhofman commented Aug 1, 2023

What is the Problem Being Solved?

When a PR updates protobuf definitions, it should also refresh the generated files, both in golang/cosmos and in packages/cosmic-proto. Currently we have some stale generated files when re-running the generation step.

Description of the Design

A required CI job that regenerates the protobuf files, and checks that the source tree is not dirty.

Security Considerations

None

Scaling Considerations

None

Test Plan

Add job, check that it catches the currently outdated cases. Then fix outdated files in same PR.

It should not be bypassable

Upgrade Considerations

None
@mhofman mhofman added enhancement New feature or request tooling repo-wide infrastructure agoric-cosmos labels Aug 1, 2023
@JimLarson JimLarson assigned JimLarson and mhofman and unassigned JimLarson Aug 2, 2023
@aj-agoric aj-agoric added the bug Something isn't working label Feb 5, 2024
@turadg turadg assigned turadg and unassigned mhofman Feb 20, 2024
@mhofman mhofman mentioned this issue Feb 20, 2024
Merged
@turadg turadg mentioned this issue Apr 1, 2024
Merged
@ivanlei ivanlei assigned ivanlei and unassigned turadg Apr 3, 2024
@turadg
Copy link
Member

turadg commented Apr 3, 2024 •
edited
Loading

#9018 that @JimLarson is working on may be a part of a broader solution.

@turadg turadg mentioned this issue Jul 3, 2024
Merged
@LuqiPan LuqiPan assigned LuqiPan and unassigned ivanlei Jul 3, 2024
@LuqiPan LuqiPan mentioned this issue Jul 5, 2024
Merged
@mergify mergify bot closed this as completed in #9656 Jul 8, 2024
@mergify mergify bot closed this as completed in 02eb9d0 Jul 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@LuqiPan LuqiPan

Labels
agoric-cosmos bug Something isn't working enhancement New feature or request tooling repo-wide infrastructure
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

ci(protobuf): check protobuf definitions are up-to-date Agoric/agoric-sdk
6 participants
@turadg @mhofman @ivanlei @LuqiPan @JimLarson @aj-agoric